Attention is currently required from: neels, pespin.

keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/34410?usp=email )

Change subject: sdp_get_sdp_mode(): fix wrong return value ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

File src/sdp.c:

https://gerrit.osmocom.org/c/osmo-sip-connector/+/34410/comment/b2c53898_85c... PS1, Line 68: return sdp_sendrecv;

sdp_sendrecv is enum sdp_mode_t from sofia-sip. […]

I guess I was probably confused between updating passed pointers like it says on the tin and returning a bool to imply failure - and not paying attention to returned types and such things. Or maybe there was some copy/paste involved. I was an even worse C programmer back in July 2019 than I am today. Hmm, compiler does not complain though. 😊