Attention is currently required from: neels, pespin. keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/34410?usp=email ) Change subject: sdp_get_sdp_mode(): fix wrong return value ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/sdp.c: https://gerrit.osmocom.org/c/osmo-sip-connector/+/34410/comment/b2c53898_85… PS1, Line 68: return sdp_sendrecv; I guess I was probably confused between updating passed pointers like it says on the tin and returning a bool to imply failure - and not paying attention to returned types and such things. Or maybe there was some copy/paste involved. I was an even worse C programmer back in July 2019 than I am today. Hmm, compiler does not complain though. 😊 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/34410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Id27eb82a018293cf54d068877dc222e1c7eab253 Gerrit-Change-Number: 34410 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 14 Sep 2023 02:56:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment