Attention is currently required from: neels, pespin.
Patch set 1:Code-Review +1
View Change
1 comment:
File src/sdp.c:
Patch Set #1, Line 68: return sdp_sendrecv;
sdp_sendrecv is enum sdp_mode_t from sofia-sip. […]
I guess I was probably confused between updating passed pointers like it says on the tin and returning a bool to imply failure - and not paying attention to returned types and such things. Or maybe there was some copy/paste involved.
I was an even worse C programmer back in July 2019 than I am today.
Hmm, compiler does not complain though. 😊
To view, visit change 34410. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: Id27eb82a018293cf54d068877dc222e1c7eab253
Gerrit-Change-Number: 34410
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith@rhizomatica.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Thu, 14 Sep 2023 02:56:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment