Attention is currently required from: iedemam. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: stats: new trackers for lchan life duration ...................................................................... Patch Set 19: (4 comments) Patchset: PS19: looks good, a minor tweak remains for me, in the comments. File src/osmo-bsc/bts_trx_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/83774c65_a30ea133 PS19, Line 576: VTY_NEWLINE); this will print nonsense values for lchan types other than SDCCH and TCH, unless we remove those conditions marked elsewhere File src/osmo-bsc/lchan_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/4aee7e57_da3225d4 PS19, Line 225: if (lchan->active_cc.cfg.rate_ctr) { let's remove this condition: always (re)start the activity time_cc, also for lchan types other than SDCCH and TCH. Hence the VTY can also show for those how long ago they have been activated. Doesn't matter whether a rate_ctr is set. https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/de467308_40a97016 PS19, Line 560: if (lchan->active_cc.cfg.rate_ctr) { remove this condition, always set the flag. Does not matter wheter a rate_ctr is set. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 19 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Comment-Date: Sat, 09 Apr 2022 15:29:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment