Attention is currently required from: iedemam.
4 comments:
Patchset:
looks good, a minor tweak remains for me, in the comments.
File src/osmo-bsc/bts_trx_vty.c:
Patch Set #19, Line 576: VTY_NEWLINE);
this will print nonsense values for lchan types other than SDCCH and TCH, unless we remove those conditions marked elsewhere
File src/osmo-bsc/lchan_fsm.c:
Patch Set #19, Line 225: if (lchan->active_cc.cfg.rate_ctr) {
let's remove this condition: always (re)start the activity time_cc, also for lchan types other than SDCCH and TCH. Hence the VTY can also show for those how long ago they have been activated. Doesn't matter whether a rate_ctr is set.
Patch Set #19, Line 560: if (lchan->active_cc.cfg.rate_ctr) {
remove this condition, always set the flag. Does not matter wheter a rate_ctr is set.
To view, visit change 27081. To unsubscribe, or for help writing mail filters, visit settings.