[S] Change in osmo-msc[master]: sqlite optimisation: Avoid unneeded database operation - gerrit-log

14 Oct 2025

Attention is currently required from: keith, pespin.

fixeria has posted comments on this change by keith. (
https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email )

Change subject: sqlite optimisation: Avoid unneeded database operation
......................................................................

Patch Set 7: Code-Review+1

(1 comment)

File src/libmsc/db.c:

https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/3398893b_f0566a9e?usp… :
PS4, Line 303: DB_STMT_SMS_DEL_EXPIRED
...
  I'd prefer to keep you happy in this patch. I can
remove the LIMIT clause. 
Thanks.

...
  I'd propose to get rid of this one (EXPIRED) an
replace its use in the code with the other one, just plain old: DB_STMT_SMS_DEL_BY_ID

Ack, this is exactly what I had in mind.

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I777155c0f818b979c636bb59953719e472771603
Gerrit-Change-Number: 28340
Gerrit-PatchSet: 7
Gerrit-Owner: keith &lt;keith(a)rhizomatica.org&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-CC: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: keith &lt;keith(a)rhizomatica.org&gt;
Gerrit-Comment-Date: Tue, 14 Oct 2025 08:34:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Comment-In-Reply-To: keith &lt;keith(a)rhizomatica.org&gt;