Attention is currently required from: keith, pespin.
Patch set 7:Code-Review +1
View Change
1 comment:
File src/libmsc/db.c:
Patch Set #4, Line 303: DB_STMT_SMS_DEL_EXPIRED
I'd prefer to keep you happy in this patch. I can remove the LIMIT clause.
Thanks.
I'd propose to get rid of this one (EXPIRED) an replace its use in the code with the other one, just plain old: DB_STMT_SMS_DEL_BY_ID
Ack, this is exactly what I had in mind.
To view, visit change 28340. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I777155c0f818b979c636bb59953719e472771603
Gerrit-Change-Number: 28340
Gerrit-PatchSet: 7
Gerrit-Owner: keith <keith@rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: keith <keith@rhizomatica.org>
Gerrit-Comment-Date: Tue, 14 Oct 2025 08:34:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Comment-In-Reply-To: keith <keith@rhizomatica.org>