Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30446 )
Change subject: Fix support for HDLC/RAW type channels at mISDN.c ......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1: fine with me now, except for the TODO-RELEASE.
File include/osmocom/abis/e1_input.h:
https://gerrit.osmocom.org/c/libosmo-abis/+/30446/comment/908c9714_f671453d PS1, Line 120: in please add an entry to TOOD-RELEASE as this breaks the ABI towards applications, i.e. we need a related .so-version change of the library when we tag the next versions.
File src/input/misdn.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/30446/comment/113998da_3df20a4e PS1, Line 690: /* TS 16 is the D-channel, so we use D-channel proto */ : bfd->fd = socket(PF_ISDN, SOCK_DGRAM, : (ts == 16) ? ISDN_P_NT_E1 : ISDN_P_B_HDLC);
mISDN handles TS 16 different, so that ISDN_P_NT_E1 must be given instead of ISDN_P_B_HDLC. […]
Oh my, that's sad. I sometimes feel like we should remove mISDN support with all its constraints. Or at least not build it by default, to avoid users falling into traps. Nobody except you seems to know/understand them, and we have no piece of documentation explaining to users that you cannot use TS16 for e.g. TRAU frames on a mISDN line.
In any case, all unrelated to this patch.
-
laforge