Attention is currently required from: jolly.

View Change

3 comments:

• Patchset:

  • Patch Set #1:

    fine with me now, except for the TODO-RELEASE.

• File include/osmocom/abis/e1_input.h:

  • Patch Set #1, Line 120: in

    please add an entry to TOOD-RELEASE as this breaks the ABI towards applications, i.e. we need a related .so-version change of the library when we tag the next versions.

• File src/input/misdn.c:

  • Patch Set #1, Line 690:

    		/* TS 16 is the D-channel, so we use D-channel proto */
    			bfd->fd = socket(PF_ISDN, SOCK_DGRAM,
    				(ts == 16) ? ISDN_P_NT_E1 : ISDN_P_B_HDLC);
    

    mISDN handles TS 16 different, so that ISDN_P_NT_E1 must be given instead of ISDN_P_B_HDLC. […]

    Oh my, that's sad. I sometimes feel like we should remove mISDN support with all its constraints. Or at least not build it by default, to avoid users falling into traps. Nobody except you seems to know/understand them, and we have no piece of documentation explaining to users that you cannot use TS16 for e.g. TRAU frames on a mISDN line.

    In any case, all unrelated to this patch.

To view, visit change 30446. To unsubscribe, or for help writing mail filters, visit settings.