Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29114 )

Change subject: contrib/libosmo-gprs.spec.in: properly define RPM packages ......................................................................

Patch Set 2:

(5 comments)

File contrib/libosmo-gprs.spec.in:

https://gerrit.osmocom.org/c/libosmo-gprs/+/29114/comment/fba3c685_99a5c545 PS2, Line 44: Osmocom GPRS RLC/MAC library Good catch, thanks for fixing this.

https://gerrit.osmocom.org/c/libosmo-gprs/+/29114/comment/b9a33ba7_6b1606ac PS2, Line 46: Group: System/Libraries Why changing tabs to spaces?

https://gerrit.osmocom.org/c/libosmo-gprs/+/29114/comment/c3ba2519_8ddc5e30 PS2, Line 56: Requires: libosmo-csn1-devel = %{version} Why changing tabs to spaces?

https://gerrit.osmocom.org/c/libosmo-gprs/+/29114/comment/aa391254_2a8d29b8 PS2, Line 72: --includedir="%_includedir/%name" Both --disable-static and --enable-shared are implicit defaults. I guess missing --includedir was the problem?

https://gerrit.osmocom.org/c/libosmo-gprs/+/29114/comment/18230766_54fff924 PS2, Line 77: find "%buildroot/%_libdir" -type f -name "*.la" -delete Interesting. This is something I also noticed while looking at *.spec files in other Osmocom projects: *-dev packages for Debian usually include lib*.{a,la,so} files, while *-devel packages for RPM based distributions do not include lib*.{a,la}. Why do we remove *.la files here if we don't list them below anyway?