Attention is currently required from: osmith.

View Change

5 comments:

• File contrib/libosmo-gprs.spec.in:

  • Patch Set #2, Line 44: Osmocom GPRS RLC/MAC library

    Good catch, thanks for fixing this.

  • Patch Set #2, Line 46: Group: System/Libraries

    Why changing tabs to spaces?

  • Patch Set #2, Line 56: Requires: libosmo-csn1-devel = %{version}

    Why changing tabs to spaces?

  • Patch Set #2, Line 72: --includedir="%_includedir/%name"

    Both --disable-static and --enable-shared are implicit defaults.
    I guess missing --includedir was the problem?

  • Patch Set #2, Line 77: find "%buildroot/%_libdir" -type f -name "*.la" -delete

    Interesting. This is something I also noticed while looking at *.spec files in other Osmocom projects: *-dev packages for Debian usually include lib*.{a,la,so} files, while *-devel packages for RPM based distributions do not include lib*.{a,la}. Why do we remove *.la files here if we don't list them below anyway?

To view, visit change 29114. To unsubscribe, or for help writing mail filters, visit settings.