[M] Change in osmo-bsc[master]: nokia_site: Add object_identity, object_state and object_identity_sta... - gerrit-log

25 Feb 2025

Attention is currently required from: domi, fixeria, laforge, pespin.

csaba.sipos has posted comments on this change by csaba.sipos. (
https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email )

Change subject: nokia_site: Add object_identity, object_state and object_identity_state
attributes
......................................................................

Patch Set 22:

(6 comments)

Patchset:

PS14: 
...
  @domi@tomcsanyi.net […] Done

Patchset:

PS22: 
...
  Just waiting for somebody else to +2 it. Done

PS22: 
...
  There were tons of unresolved review comments here; I
usually only review code that either has no re […] Done

File src/osmo-bsc/bts_nokia_site.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/418267a1_0ce2f5e1?usp… :
PS11, Line 1828: 			get_object_identity_string(object_id_state[4]), object_id_state[5],
get_object_state_string(object_id_state[10]));
...
  Please, as mentioned, keep lines belows 120chars,
otherwise it's a mess. This is far more readable: […] Done

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/bc925776_c2df549f?usp… :
PS11, Line 1859: 			find_element(noh->data, len_data, NOKIA_EI_OBJ_STATE,
&object_state, sizeof(object_state))
...
  Again, all the indentation choices you are selecting
here make it impossible to follow. […] Done

https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/005f1da3_905fe508?usp… :
PS11, Line 1863: 				object_identity[1] = object_id_state[4];
...
  so basically object_identity[0] is left uninitialized
in this code path? same for object_identity[3] […] Done

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id9f819b0649ba3c247db72d7d738e49c72388dc3
Gerrit-Change-Number: 39416
Gerrit-PatchSet: 22
Gerrit-Owner: csaba.sipos &lt;metro4(a)freemail.hu&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-CC: domi &lt;domi(a)tomcsanyi.net&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Attention: domi &lt;domi(a)tomcsanyi.net&gt;
Gerrit-Comment-Date: Tue, 25 Feb 2025 13:43:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: csaba.sipos &lt;metro4(a)freemail.hu&gt;
Comment-In-Reply-To: laforge &lt;laforge(a)osmocom.org&gt;
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;