Attention is currently required from: domi, fixeria, laforge, pespin.
6 comments:
Patchset:
@domi@tomcsanyi.net […]
Done
Patchset:
Just waiting for somebody else to +2 it.
Done
There were tons of unresolved review comments here; I usually only review code that either has no re […]
Done
File src/osmo-bsc/bts_nokia_site.c:
Patch Set #11, Line 1828: get_object_identity_string(object_id_state[4]), object_id_state[5], get_object_state_string(object_id_state[10]));
Please, as mentioned, keep lines belows 120chars, otherwise it's a mess. This is far more readable: […]
Done
Patch Set #11, Line 1859: find_element(noh->data, len_data, NOKIA_EI_OBJ_STATE, &object_state, sizeof(object_state))
Again, all the indentation choices you are selecting here make it impossible to follow. […]
Done
Patch Set #11, Line 1863: object_identity[1] = object_id_state[4];
so basically object_identity[0] is left uninitialized in this code path? same for object_identity[3] […]
Done
To view, visit change 39416. To unsubscribe, or for help writing mail filters, visit settings.