Attention is currently required from: pespin.

osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38469?usp=email )

Change subject: ggsn: Introduce test TC_pdp4(6)_act_deact_mtu ......................................................................

Patch Set 3:

(5 comments)

File ggsn_tests/GGSN_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38469/comment/2505364b_47226... : PS3, Line 248: f_vty_transceive(GGSNVTY, "apn internet"); "apn internet" is in "all" and "v4_only" configs, see the confmerge files here: https://gitea.osmocom.org/ttcn3/osmo-ttcn3-hacks/src/branch/master/ggsn_test...

Therefore I think we need to wrap this in: if (m_ggsn_conf == GGSN_CONF_ALL || m_ggsn_conf == GGSN_CONF_V4_ONLY) {

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38469/comment/10935547_60374... : PS3, Line 252: f_vty_transceive(GGSNVTY, "apn inet6"); if (m_ggsn_conf == GGSN_CONF_ALL || m_ggsn_conf == GGSN_CONF_V6_ONLY) {

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38469/comment/c1f5ce80_a4729... : PS3, Line 256: f_vty_transceive(GGSNVTY, "apn inet46"); if (m_ggsn_conf == GGSN_CONF_ALL || m_ggsn_conf == GGSN_CONF_V4V6_ONLY) {

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38469/comment/c38c45d7_49bf9... : PS3, Line 2360: execute(TC_pdp4_act_deact_mtu()); wrap in `if (m_ggsn_impl == GGSN_IMPL_OSMOCOM) {`, and same below for `TC_pdp46_act_deact_mtu`, since the VTY code will only work with osmo-ggsn?

File library/GTPv1C_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38469/comment/bf36e86a_0111d... : PS3, Line 1229: unrelated change