Attention is currently required from: pespin.

View Change

5 comments:

• File ggsn_tests/GGSN_Tests.ttcn:

  • Patch Set #3, Line 248: f_vty_transceive(GGSNVTY, "apn internet");

    "apn internet" is in "all" and "v4_only" configs, see the confmerge files here:
    https://gitea.osmocom.org/ttcn3/osmo-ttcn3-hacks/src/branch/master/ggsn_tests/osmo-ggsn

    Therefore I think we need to wrap this in:
    if (m_ggsn_conf == GGSN_CONF_ALL || m_ggsn_conf == GGSN_CONF_V4_ONLY) {

  • Patch Set #3, Line 252: f_vty_transceive(GGSNVTY, "apn inet6");

    if (m_ggsn_conf == GGSN_CONF_ALL || m_ggsn_conf == GGSN_CONF_V6_ONLY) {

  • Patch Set #3, Line 256: f_vty_transceive(GGSNVTY, "apn inet46");

    if (m_ggsn_conf == GGSN_CONF_ALL || m_ggsn_conf == GGSN_CONF_V4V6_ONLY) {

  • Patch Set #3, Line 2360: execute(TC_pdp4_act_deact_mtu());

    wrap in `if (m_ggsn_impl == GGSN_IMPL_OSMOCOM) {`, and same below for `TC_pdp46_act_deact_mtu`, since the VTY code will only work with osmo-ggsn?

• File library/GTPv1C_Templates.ttcn:

  • Patch Set #3, Line 1229:

    unrelated change

To view, visit change 38469. To unsubscribe, or for help writing mail filters, visit settings.