Attention is currently required from: jolly, laforge.

pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40489?usp=email )

Change subject: Allow io_uring_submit batching just ahead of poll/select ......................................................................

Patch Set 3:

(2 comments)

Patchset:

PS3: I'm still not convinced we want to add more envvars. This is something we can probably configure through VTY. Only reason I see for having a envvar is in the event we want to have this opt-in for a while and later on enable it and remove the envvar.

File src/core/select.c:

https://gerrit.osmocom.org/c/libosmocore/+/40489/comment/325868c5_e2d4e50a?u... : PS3, Line 440: osmo_io_uring_submit(); I'd say it makes more sense to have the OSMO_UNLIKELY if here directly, to avoid an extra call+ret on each loop iteration.

Maybe as a C macro if you want to keep it similar.