Attention is currently required from: jolly, laforge.

View Change

2 comments:

• Patchset:

  • Patch Set #3:

    I'm still not convinced we want to add more envvars. This is something we can probably configure through VTY.
    Only reason I see for having a envvar is in the event we want to have this opt-in for a while and later on enable it and remove the envvar.

• File src/core/select.c:

  • Patch Set #3, Line 440: osmo_io_uring_submit();

    I'd say it makes more sense to have the OSMO_UNLIKELY if here directly, to avoid an extra call+ret on each loop iteration.

    Maybe as a C macro if you want to keep it similar.

To view, visit change 40489. To unsubscribe, or for help writing mail filters, visit settings.