Attention is currently required from: arehbein. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30602 )

Change subject: WIP: vty: Add check against sensible default value for Ny1 ......................................................................

Patch Set 5: Code-Review-1

(4 comments)

File include/osmocom/bsc/bts.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/1fd65c6d_f937f8bf PS5, Line 837: static inline bool gsm_bts_check_ny1 Is it really necessary to have this function static inline in a header? Is it used in hot code paths and so always needs to be inlined?

https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/03752b92_d545aff6 PS5, Line 839: struct gsm_lchan *gl const also, who does 'gl' mean?

https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/f2761074_45e7c7b8 PS5, Line 842: if (gl) { Not critical, but could be done a bit simpler:

unsigned long T3124 = GSM_T3124_SDCCH; if (gl && gl->type != GSM_LCHAN_SDCCH) T3124 = GSM_T3124_OTHER_CH;

https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/8fcacfda_565afadf PS5, Line 855: talloc_strdup_append Looks way too complicated, IMO. How about this?

LOGP(DNM, log_level, "%s Is: %lu Lowest recommendation: %lu\n", msg, ny1, (T3124 + GSM_NY1_REQ_DELTA) / T3105 + 1);