Attention is currently required from: arehbein.

Patch set 5:Code-Review -1

View Change

4 comments:

• File include/osmocom/bsc/bts.h:

  • Patch Set #5, Line 837: static inline bool gsm_bts_check_ny1

    Is it really necessary to have this function static inline in a header?
    Is it used in hot code paths and so always needs to be inlined?

  • Patch Set #5, Line 839: struct gsm_lchan *gl

    const
    also, who does 'gl' mean?

  • Patch Set #5, Line 842: if (gl) {

    Not critical, but could be done a bit simpler:

      unsigned long T3124 = GSM_T3124_SDCCH;
      if (gl && gl->type != GSM_LCHAN_SDCCH)
        T3124 = GSM_T3124_OTHER_CH;

  • Patch Set #5, Line 855: talloc_strdup_append

    Looks way too complicated, IMO. How about this?

      LOGP(DNM, log_level, "%s Is: %lu Lowest recommendation: %lu\n",
           msg, ny1, (T3124 + GSM_NY1_REQ_DELTA) / T3105 + 1);

To view, visit change 30602. To unsubscribe, or for help writing mail filters, visit settings.