Attention is currently required from: arehbein, laforge, pespin.

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email )

Change subject: gsmtap: Hide implementation of gsmtap_inst ......................................................................

Patch Set 2:

(2 comments)

Patchset:

PS2:

I didn't prefix the function with osmo_-anything, because the other functions in gsmtap_util. […]

That's okay, we want to keep it consistent. The reason for the missing osmo_* is that this is very early code and we simply didn't use any common prefix back then. Now we're stuck with it due to backwards compatibility.

File src/core/libosmocore.map:

https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/a65667de_1be9595f PS2, Line 42: gsmtap_inst_fd; Not sure if this needs a line in TODO-RELEASE? It seems like an addition to the ABI, even if it was static inline in the header before.