Attention is currently required from: arehbein, laforge, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email ) Change subject: gsmtap: Hide implementation of gsmtap_inst ...................................................................... Patch Set 2: (2 comments) Patchset: PS2:
I didn't prefix the function with osmo_-anything, because the other functions in gsmtap_util. […] That's okay, we want to keep it consistent. The reason for the missing osmo_* is that this is very early code and we simply didn't use any common prefix back then. Now we're stuck with it due to backwards compatibility.
File src/core/libosmocore.map: https://gerrit.osmocom.org/c/libosmocore/+/34720/comment/a65667de_1be9595f PS2, Line 42: gsmtap_inst_fd; Not sure if this needs a line in TODO-RELEASE? It seems like an addition to the ABI, even if it was static inline in the header before. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34720?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibe1a51205a6df764571b6d074e365825555609a5 Gerrit-Change-Number: 34720 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: arehbein <arehbein@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 12 Oct 2023 06:41:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein@sysmocom.de> Gerrit-MessageType: comment