Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30568 )
Change subject: Get rid of tbf->first_ts ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-pcu/+/30568/comment/2012454a_8f5023c1 PS1, Line 9: quickly
Not going to block you work, but are you sure this is not causing any noticeable performance regress […]
Yes, I checked this is not used in hot code paths. It is only used in gen_freq_params() (encode PktDlAss and PktUlAss), in bts_snd_dl_ass() when sending a DL ImmAss, and during rach req for 1phase-access.
In those cases iterating 0..7 instead of direct access is not important at all.
File src/tbf.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/30568/comment/c69b6b61_961c58b4 PS1, Line 899: 8
Ack, ARRAY_SIZE(tbf->pdch) should work here.
This loop formula is used in lots of places in osmo-pcu already, but yeah, I can update it to use ARRAY_SIZE.
https://gerrit.osmocom.org/c/osmo-pcu/+/30568/comment/af7e385c_fe1ebd11 PS1, Line 911: 8
Same here.
Ack
-
pespin