Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30568 ) Change subject: Get rid of tbf->first_ts ...................................................................... Patch Set 1: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/30568/comment/2012454a_8f5023c1 PS1, Line 9: quickly Yes, I checked this is not used in hot code paths. It is only used in gen_freq_params() (encode PktDlAss and PktUlAss), in bts_snd_dl_ass() when sending a DL ImmAss, and during rach req for 1phase-access. In those cases iterating 0..7 instead of direct access is not important at all. File src/tbf.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/30568/comment/c69b6b61_961c58b4 PS1, Line 899: 8 This loop formula is used in lots of places in osmo-pcu already, but yeah, I can update it to use ARRAY_SIZE. https://gerrit.osmocom.org/c/osmo-pcu/+/30568/comment/af7e385c_fe1ebd11 PS1, Line 911: 8 Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30568 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5d2f665f648f8637466bfdd3bf7b924cb61ede33 Gerrit-Change-Number: 30568 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Dec 2022 12:03:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment