Attention is currently required from: laforge, fixeria.

View Change

3 comments:

• Commit Message:

  • Patch Set #1, Line 9: quickly

    Not going to block you work, but are you sure this is not causing any noticeable performance regress […]

    Yes, I checked this is not used in hot code paths. It is only used in gen_freq_params() (encode PktDlAss and PktUlAss), in bts_snd_dl_ass() when sending a DL ImmAss, and during rach req for 1phase-access.

    In those cases iterating 0..7 instead of direct access is not important at all.

• File src/tbf.cpp:

  • Patch Set #1, Line 899: 8

    Ack, ARRAY_SIZE(tbf->pdch) should work here.

    This loop formula is used in lots of places in osmo-pcu already, but yeah, I can update it to use ARRAY_SIZE.

  • Patch Set #1, Line 911: 8

    Same here.

    Ack

To view, visit change 30568. To unsubscribe, or for help writing mail filters, visit settings.