Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266 ) Change subject: Pass AMR codec info over L1CTL ...................................................................... Patch Set 2: (5 comments) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266/comment/8f26b070_ec46… PS2, Line 2513: 0 Can also be made configurable via g_pars.amr_start_codec. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266/comment/b47008be_2acc… PS2, Line 2521: 00000100 I suggest to make this value configurable via g_pars.amr_codecs. File library/L1CTL_PortType.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266/comment/bcf59314_2f11… PS2, Line 110: tch_mode_req_tmpl Unusual naming. I would omit the '_tmpl'. Not critical though. File library/L1CTL_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266/comment/3d617ab8_1a45… PS2, Line 184: start_codec Either prefix both fields with 'amr_', or wrap into a record: type record L1ctlTchModeConf { ... // Yes, anonymous records/unions are supported record { uint8_t start_codec, BIT8 codecs_bitmask } amr }; https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266/comment/8bea1454_bd0a… PS2, Line 288: start_codec Same here. You may also define it as a separate record to avoid code dup. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3db7f6a4b7819b16ada83862f2a5409db4fa21f9 Gerrit-Change-Number: 29266 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 02 Sep 2022 18:29:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment