Attention is currently required from: pespin.

View Change

5 comments:

• File bts/BTS_Tests.ttcn:

  • Patch Set #2, Line 2513: 0

    Can also be made configurable via g_pars.amr_start_codec.

  • Patch Set #2, Line 2521: 00000100

    I suggest to make this value configurable via g_pars.amr_codecs.

• File library/L1CTL_PortType.ttcn:

  • Patch Set #2, Line 110: tch_mode_req_tmpl

    Unusual naming. I would omit the '_tmpl'. Not critical though.

• File library/L1CTL_Types.ttcn:

  • Patch Set #2, Line 184: start_codec

    Either prefix both fields with 'amr_', or wrap into a record:

      type record L1ctlTchModeConf {
        ...
        // Yes, anonymous records/unions are supported
        record {
          uint8_t  start_codec,
          BIT8     codecs_bitmask
        } amr
      };

  • Patch Set #2, Line 288: start_codec

    Same here. You may also define it as a separate record to avoid code dup.

To view, visit change 29266. To unsubscribe, or for help writing mail filters, visit settings.