Attention is currently required from: neels, laforge, dexter. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28848 ) Change subject: SMPP: move read/write callbacks to libsmpputil ...................................................................... Patch Set 29: (6 comments) This change is ready for review. Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/28848/comment/ae9590ca_0473d3d3 PS28, Line 7: SMPP: move read/write callbacks to libsmpputil Done Patchset: PS29: The fixes are included into next revision. File include/osmocom/smpp/smpp.h: https://gerrit.osmocom.org/c/osmo-msc/+/28848/comment/99471e7b_11b17d10 PS28, Line 51: + * osmo_fd to properly check for errors. Done https://gerrit.osmocom.org/c/osmo-msc/+/28848/comment/ba12ec78_4e4c538c PS28, Line 53: + * an error. The code there should handle closing the connection. Done https://gerrit.osmocom.org/c/osmo-msc/+/28848/comment/820325a5_a2a32abb PS28, Line 55: + * projects as well. I'm also not convinced this is worth moving to libosmocore - I don't think macro with flow control is a good idea in general. But that's the comment in the comment in the original code - I've simply kept it in place while moving it. I also keep the name intact for the same reason. File src/libsmpputil/smpp_utils.c: https://gerrit.osmocom.org/c/osmo-msc/+/28848/comment/816b746f_6f579534 PS28, Line 58: /* !\brief call-back when per-ESME TCP socket has some data to be read */ Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I875eb5249004d3a960aee46c5099592d18fcaa76 Gerrit-Change-Number: 28848 Gerrit-PatchSet: 29 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Sep 2022 05:55:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment