Attention is currently required from: neels, laforge, dexter.
6 comments:
Commit Message:
Patch Set #28, Line 7: SMPP: move read/write callbacks to libsmpputil
would be good to give a reason for the move / which other caller is currently expected
Done
Patchset:
The fixes are included into next revision.
File include/osmocom/smpp/smpp.h:
Patch Set #28, Line 51: + * osmo_fd to properly check for errors.
you have diff '+' leaked into the C code
Done
Patch Set #28, Line 53: + * an error. The code there should handle closing the connection.
I would prefer to keep this macro confined locally to a .c file, i guess smpp_utils.c […]
Done
Patch Set #28, Line 55: + * projects as well.
hmm idk. […]
I'm also not convinced this is worth moving to libosmocore - I don't think macro with flow control is a good idea in general. But that's the comment in the comment in the original code - I've simply kept it in place while moving it. I also keep the name intact for the same reason.
File src/libsmpputil/smpp_utils.c:
Patch Set #28, Line 58: /* !\brief call-back when per-ESME TCP socket has some data to be read */
drop \brief, see https://osmocom. […]
Done
To view, visit change 28848. To unsubscribe, or for help writing mail filters, visit settings.