Attention is currently required from: fixeria, pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/38553?usp=email )
Change subject: CSD: implement half-rate modes correctly ......................................................................
Patch Set 3:
(4 comments)
File include/osmo-bts/csd_v110.h:
https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/dd2c453c_c9282eea?usp=... : PS2, Line 11: uint8_t ra2_ir;
It is the intermediate rate (8 or 16 kbit/s) to be used in the RA2 packing/unpacking step.
I added the comment as requested.
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/0095f1d4_b2bd47ff?usp=... : PS2, Line 1539: 2
Will do.
Done
https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/ee232fef_a6e19a34?usp=... : PS2, Line 1556: else
Will do.
Done
https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/94ed31f8_43fa1da6?usp=... : PS2, Line 2098: switch (lchan->tch_mode) {
Not sure if I agree - let me handle all other feedback first, then I'll get back to this one.
I looked into doing what you suggested, but I like my original approach better. In the two code paths in question (one for CSD-HR UL, the other for CSD-HR DL), the only valid modes are 6.0k and 3.6k raw rates, and my code does OSMO_ASSERT on all others. Changing the code to use `csd_v110_lchan_desc[]` would entail allowing invalid modes, or more complicated error checks. Perhaps leave this part as is?
-
falconia