Attention is currently required from: fixeria, pespin.

View Change

4 comments:

• File include/osmo-bts/csd_v110.h:

  • Patch Set #2, Line 11: uint8_t ra2_ir;

    It is the intermediate rate (8 or 16 kbit/s) to be used in the RA2 packing/unpacking step.

    I added the comment as requested.

• File src/common/l1sap.c:

  • Patch Set #2, Line 1539: 2

    Will do.

    Done

  • Patch Set #2, Line 1556: else

    Will do.

    Done

  • Patch Set #2, Line 2098: switch (lchan->tch_mode) {

    Not sure if I agree - let me handle all other feedback first, then I'll get back to this one.

    I looked into doing what you suggested, but I like my original approach better. In the two code paths in question (one for CSD-HR UL, the other for CSD-HR DL), the only valid modes are 6.0k and 3.6k raw rates, and my code does OSMO_ASSERT on all others. Changing the code to use `csd_v110_lchan_desc[]` would entail allowing invalid modes, or more complicated error checks. Perhaps leave this part as is?

To view, visit change 38553. To unsubscribe, or for help writing mail filters, visit settings.