Change in pysim[master]: ts_102_221: The BTLV IEs FILE SIZE and TOTAL FILE SIZE have a min length - gerrit-log

11 Jun 2022


      Attention is currently required from: fixeria, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28185 )
Change subject: ts_102_221: The BTLV IEs FILE SIZE and TOTAL FILE SIZE have a min length
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
File pySim/construct.py:
https://gerrit.osmocom.org/c/pysim/+/28185/comment/b7c90ece_569701a7 
PS5, Line 241:         if nbytes < minlen:
...
I do not insist on using min() here, but could you please explain (or give an example) what's wrong  […]
I really don't think either of you needs to spend any more time on this.
-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/28185
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ief113ce8fe3bcae2c9fb2ff4138df9ccf98d26ff
Gerrit-Change-Number: 28185
Gerrit-PatchSet: 9
Gerrit-Owner: dexter pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: dexter pmaier@sysmocom.de
Gerrit-Comment-Date: Sat, 11 Jun 2022 06:04:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Comment-In-Reply-To: dexter pmaier@sysmocom.de
Gerrit-MessageType: comment