Attention is currently required from: fixeria, dexter.
Patch set 9:Code-Review +2
View Change
1 comment:
File pySim/construct.py:
Patch Set #5, Line 241: if nbytes < minlen:
I do not insist on using min() here, but could you please explain (or give an example) what's wrong […]
I really don't think either of you needs to spend any more time on this.
To view, visit change 28185. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ief113ce8fe3bcae2c9fb2ff4138df9ccf98d26ff
Gerrit-Change-Number: 28185
Gerrit-PatchSet: 9
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Sat, 11 Jun 2022 06:04:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Comment-In-Reply-To: dexter <pmaier@sysmocom.de>
Gerrit-MessageType: comment