Attention is currently required from: pespin, msuraev.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28849 )
Change subject: libosmonetify SMPP ......................................................................
Patch Set 66:
(1 comment)
File src/libsmpputil/smpp_vty.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/2d6fd242_31d34e53 PS49, Line 190: vty_out(vty, " local-tcp-port %u%s", smsc->listen_port ? smsc->listen_port : SMPP_PORT, VTY_NEWLINE);
You are clearly changing this line in this commit. […]
I tend to agree with pau. Either this patch changes something about smsc->listen_port initialization (and thea above line adjustst he config_write_smpp to accomodate that). This would be fine, but I don't see evidence to that? Or this change is a completely unrelated change and fixes a bug in the original code where we would print "local-tcp-port 0" in the vty? At least some clarification is needed. It looks fishy.
-
laforge