Attention is currently required from: pespin, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28849 ) Change subject: libosmonetify SMPP ...................................................................... Patch Set 66: (1 comment) File src/libsmpputil/smpp_vty.c: https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/2d6fd242_31d34e53 PS49, Line 190: vty_out(vty, " local-tcp-port %u%s", smsc->listen_port ? smsc->listen_port : SMPP_PORT, VTY_NEWLINE);
You are clearly changing this line in this commit. […] I tend to agree with pau. Either this patch changes something about smsc->listen_port initialization (and thea above line adjustst he config_write_smpp to accomodate that). This would be fine, but I don't see evidence to that? Or this change is a completely unrelated change and fixes a bug in the original code where we would print "local-tcp-port 0" in the vty? At least some clarification is needed. It looks fishy.
-- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28849 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Idc2e60af1010783e555e61b114ae61f55a89d890 Gerrit-Change-Number: 28849 Gerrit-PatchSet: 66 Gerrit-Owner: msuraev <msuraev@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: msuraev <msuraev@sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 11:38:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: msuraev <msuraev@sysmocom.de> Gerrit-MessageType: comment