Jenkins Builder has posted comments on this change by canghaiwuhen. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42050?usp=email )

Change subject: Related: OS#6922 ......................................................................

Patch Set 1:

(23 comments)

File src/sgsn/gprs_gmm.c:

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/36a304fd_1963b170?usp... : PS1, Line 1339: } else { suspect code indent for conditional statements (16, 16)

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/a7704c08_a53fd771?usp... : PS1, Line 1340: /* [FIX] Known IMSI context. If the module initiates an Attach, it means it has restarted and lost its PDP state. trailing whitespace

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/1ecd01d8_618e6ab0?usp... : PS1, Line 1343: llist_for_each_entry_safe(pdp, pdp2, &ctx->pdp_list, list) { code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/ba367cd1_36f13359?usp... : PS1, Line 1343: llist_for_each_entry_safe(pdp, pdp2, &ctx->pdp_list, list) { please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/3ebf64e3_c422fcee?usp... : PS1, Line 1344: LOGMMCTXP(LOGL_NOTICE, ctx, "Re-Attach: Dropping stale PDP context for NSAPI=%u\n", pdp->nsapi); code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/9f4fa900_e621bca3?usp... : PS1, Line 1344: LOGMMCTXP(LOGL_NOTICE, ctx, "Re-Attach: Dropping stale PDP context for NSAPI=%u\n", pdp->nsapi); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/4d385e39_a59eef23?usp... : PS1, Line 1345: sgsn_pdp_ctx_terminate(pdp); code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/c588ff69_76708ed7?usp... : PS1, Line 1345: sgsn_pdp_ctx_terminate(pdp); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/ee06450f_d6b8ae96?usp... : PS1, Line 1346: } code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/db586fa3_dd4d3f6d?usp... : PS1, Line 1346: } please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/a7f13413_bd46ceba?usp... : PS1, Line 1347: } code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/672f8564_de51ceda?usp... : PS1, Line 1347: } please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/e286c88a_bb0b2d21?usp... : PS1, Line 1365: } else { suspect code indent for conditional statements (16, 16)

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/d88b8ec5_194dccfe?usp... : PS1, Line 1368: llist_for_each_entry_safe(pdp, pdp2, &ctx->pdp_list, list) { code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/d4b84f68_c4d2e32c?usp... : PS1, Line 1368: llist_for_each_entry_safe(pdp, pdp2, &ctx->pdp_list, list) { please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/55f6a26a_2aeaa9ed?usp... : PS1, Line 1369: LOGMMCTXP(LOGL_NOTICE, ctx, "Re-Attach: Dropping stale PDP context for NSAPI=%u\n", pdp->nsapi); code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/984eac07_d870c12c?usp... : PS1, Line 1369: LOGMMCTXP(LOGL_NOTICE, ctx, "Re-Attach: Dropping stale PDP context for NSAPI=%u\n", pdp->nsapi); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/1521fbeb_c4c5fa49?usp... : PS1, Line 1370: sgsn_pdp_ctx_terminate(pdp); code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/8eb7ab31_14b82d26?usp... : PS1, Line 1370: sgsn_pdp_ctx_terminate(pdp); please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/df5160df_b9b34f05?usp... : PS1, Line 1371: } code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/13ae0381_201c4947?usp... : PS1, Line 1371: } please, no spaces at the start of a line

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/20a8c15f_9b501f2e?usp... : PS1, Line 1372: } code indent should use tabs where possible

Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/42050/comment/28d197bd_f02078b2?usp... : PS1, Line 1372: } please, no spaces at the start of a line