View Change

23 comments:

• File src/sgsn/gprs_gmm.c:

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1339: } else {

    suspect code indent for conditional statements (16, 16)

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1340: /* [FIX] Known IMSI context. If the module initiates an Attach, it means it has restarted and lost its PDP state.

    trailing whitespace

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1343: llist_for_each_entry_safe(pdp, pdp2, &ctx->pdp_list, list) {

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1343: llist_for_each_entry_safe(pdp, pdp2, &ctx->pdp_list, list) {

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1344: LOGMMCTXP(LOGL_NOTICE, ctx, "Re-Attach: Dropping stale PDP context for NSAPI=%u\n", pdp->nsapi);

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1344: LOGMMCTXP(LOGL_NOTICE, ctx, "Re-Attach: Dropping stale PDP context for NSAPI=%u\n", pdp->nsapi);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1345: sgsn_pdp_ctx_terminate(pdp);

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1345: sgsn_pdp_ctx_terminate(pdp);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1346: }

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1346: }

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1347: }

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1347: }

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1365: } else {

    suspect code indent for conditional statements (16, 16)

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1368: llist_for_each_entry_safe(pdp, pdp2, &ctx->pdp_list, list) {

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1368: llist_for_each_entry_safe(pdp, pdp2, &ctx->pdp_list, list) {

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1369: LOGMMCTXP(LOGL_NOTICE, ctx, "Re-Attach: Dropping stale PDP context for NSAPI=%u\n", pdp->nsapi);

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1369: LOGMMCTXP(LOGL_NOTICE, ctx, "Re-Attach: Dropping stale PDP context for NSAPI=%u\n", pdp->nsapi);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1370: sgsn_pdp_ctx_terminate(pdp);

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1370: sgsn_pdp_ctx_terminate(pdp);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1371: }

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1371: }

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1372: }

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID ):

    Patch Set #1, Line 1372: }

    please, no spaces at the start of a line

To view, visit change 42050. To unsubscribe, or for help writing mail filters, visit settings.