Attention is currently required from: pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email )

Change subject: Re-introduce Iu/UTRAN support ......................................................................

Patch Set 3:

(4 comments)

File src/sgsn/gprs_routing_area.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/12ce160b_f13e25bf?usp... : PS2, Line 439: } else {

You can move this code path above as an early return.

Done

https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/1f550c1d_fd38f9cf?usp... : PS2, Line 483: else if (mmctx->p_tmsi_old != GSM_RESERVED_TMSI)

these "else" here and below are not needed since you are doing early return.

Done

File tests/gprs_routing_area/gprs_routing_area_test.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/4a3591c6_07995963?usp... : PS2, Line 541: /* check if a GERAN RA/cell with the same LAC as an already register UTRAN gets rejected */

registered?

I switched to a different wording.

https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/277d8359_0465ad6c?usp... : PS2, Line 542: void test_routing_area_mv_utran_geran_reject(void)

I think it's worth explaining here that this is an implementation decision we took and that it's not […]

Done