Attention is currently required from: pespin.

View Change

4 comments:

• File src/sgsn/gprs_routing_area.c:

  • Patch Set #2, Line 439: } else {

    You can move this code path above as an early return.

    Done

  • Patch Set #2, Line 483: else if (mmctx->p_tmsi_old != GSM_RESERVED_TMSI)

    these "else" here and below are not needed since you are doing early return.

    Done

• File tests/gprs_routing_area/gprs_routing_area_test.c:

  • Patch Set #2, Line 541: /* check if a GERAN RA/cell with the same LAC as an already register UTRAN gets rejected */

    registered?

    I switched to a different wording.

  • Patch Set #2, Line 542: void test_routing_area_mv_utran_geran_reject(void)

    I think it's worth explaining here that this is an implementation decision we took and that it's not […]

    Done

To view, visit change 40813. To unsubscribe, or for help writing mail filters, visit settings.