Attention is currently required from: jolly.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email )

Change subject: Add LLC and HLC transcoding to MNCC transcoding functions ......................................................................

Patch Set 1:

(3 comments)

File include/osmocom/gsm/gsm48_ie.h:

https://gerrit.osmocom.org/c/libosmocore/+/35391/comment/57b106c8_dca51d27 PS1, Line 39: /* decode 'high layer complatibility' */ "compatibility" in all lines.

File include/osmocom/gsm/mncc.h:

https://gerrit.osmocom.org/c/libosmocore/+/35391/comment/bcfd6de6_f0ebd6f0 PS1, Line 35: struct gsm_mncc_lowl_compat { some spec reference on what is this about would be nice.

File src/gsm/gsm48_ie.c:

https://gerrit.osmocom.org/c/libosmocore/+/35391/comment/9de75357_8b6ce68c PS1, Line 412: /*! Encode TS 04.08 High Layer compatibility IE (10.5.4.16) */ All this looks a bit overkill to me, having a struct containing a len field and a buffer, and then copying it over to yet another local buffer to then yet again copy it over to the msg...