Attention is currently required from: jolly.

View Change

3 comments:

• File include/osmocom/gsm/gsm48_ie.h:

  • Patch Set #1, Line 39: /* decode 'high layer complatibility' */

    "compatibility" in all lines.

• File include/osmocom/gsm/mncc.h:

  • Patch Set #1, Line 35: struct gsm_mncc_lowl_compat {

    some spec reference on what is this about would be nice.

• File src/gsm/gsm48_ie.c:

  • Patch Set #1, Line 412: /*! Encode TS 04.08 High Layer compatibility IE (10.5.4.16) */

    All this looks a bit overkill to me, having a struct containing a len field and a buffer, and then copying it over to yet another local buffer to then yet again copy it over to the msg...

To view, visit change 35391. To unsubscribe, or for help writing mail filters, visit settings.