Attention is currently required from: pespin, dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33312 )
Change subject: mgw: Allow auditing speciall 'null' endpoint ......................................................................
Patch Set 2:
(1 comment)
File src/libosmo-mgcp/mgcp_endp.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/33312/comment/0cf3afbf_c8ebdf24 PS2, Line 237: strstr From the man page:
``` DESCRIPTION The strstr() function finds the first occurrence of the substring needle in the string haystack.
RETURN VALUE These functions return a pointer to the beginning of the located substring, or NULL if the substring is not found.
```
This means that basically any endpoint name containing `null` would be considered a null-endpoint (e.g. epname="notanull")? Maybe better use `strncmp(epname, "null", 4)` or even `strncmp(epname, "null@", 5)` here instead?