Attention is currently required from: pespin, dexter.

View Change

1 comment:

• File src/libosmo-mgcp/mgcp_endp.c:

  • Patch Set #2, Line 237: strstr

    From the man page:

    ```
    DESCRIPTION
    The strstr() function finds the first occurrence of the substring needle in the string haystack.

    RETURN VALUE
    These functions return a pointer to the beginning of the located substring, or NULL if the substring is not found.

    ```

    This means that basically any endpoint name containing `null` would be considered a null-endpoint (e.g. epname="notanull")? Maybe better use `strncmp(epname, "null", 4)` or even `strncmp(epname, "null@", 5)` here instead?

To view, visit change 33312. To unsubscribe, or for help writing mail filters, visit settings.