Attention is currently required from: pespin. neels has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/40633?usp=email ) Change subject: ran_peer: Introuce stats msc.ran_peers.{total,active} ...................................................................... Patch Set 4: Code-Review-1 (2 comments) File include/osmocom/msc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-msc/+/40633/comment/12389ce5_8ff9c31c?usp… : PS4, Line 127: [MSC_STAT_RAN_PEERS_TOTAL] = { "msc.ran_peers.total", "Total RAN peers (BSC, RNC)", OSMO_STAT_ITEM_NO_UNIT, 4, 0}, (maybe add "seen"? like "Total RAN peers seen since startup" ... just thinking to clarify the difference between TOTAL and ACTIVE) File src/libmsc/ran_peer.c: https://gerrit.osmocom.org/c/osmo-msc/+/40633/comment/d81c63e8_1d062bf6?usp… : PS4, Line 95: osmo_stat_item_dec(osmo_stat_item_group_get_item(net->statg, MSC_STAT_RAN_PEERS_TOTAL), 1); you already count the state change in onleave(), so just make sure to change the state before/on deallocation. This FSM has a DISCARDING state exactly for this purpose. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40633?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I36e40510c9a95f0c9cf5f32d2a7baab840aa8660 Gerrit-Change-Number: 40633 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Jul 2025 14:02:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes