Attention is currently required from: pespin.

Patch set 4:Code-Review -1

View Change

2 comments:

• File include/osmocom/msc/gsm_data.h:

  • Patch Set #4, Line 127: [MSC_STAT_RAN_PEERS_TOTAL] = { "msc.ran_peers.total", "Total RAN peers (BSC, RNC)", OSMO_STAT_ITEM_NO_UNIT, 4, 0},

    (maybe add "seen"? like "Total RAN peers seen since startup" ... just thinking to clarify the difference between TOTAL and ACTIVE)

• File src/libmsc/ran_peer.c:

  • Patch Set #4, Line 95: osmo_stat_item_dec(osmo_stat_item_group_get_item(net->statg, MSC_STAT_RAN_PEERS_TOTAL), 1);

    you already count the state change in onleave(), so just make sure to change the state before/on deallocation. This FSM has a DISCARDING state exactly for this purpose.

To view, visit change 40633. To unsubscribe, or for help writing mail filters, visit settings.