Attention is currently required from: lynxis lazus, pespin.

fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email )

Change subject: Add test for tcap decoding/encoding ......................................................................

Patch Set 6: Code-Review-1

(1 comment)

Patchset:

PS6: This test does not cover (nor require) any API from libosmo-sigtran. It's a binary that links against libosmo-asn1-tcap and tests the API of libosmo-asn1-tcap. This is why it's weird to have such a test here: it just does not belong here.

It ensures the library works correctly. We had issues in the past with linking again asn1 libraries.

What kind of issues do we catch by having the test here that we would not be able to catch if we move it to libosmo-asn1-tcap.git? For the linker there's no difference where the test binary is...