Attention is currently required from: lynxis lazus, pespin.
Patch set 6:Code-Review -1
View Change
1 comment:
Patchset:
Patch Set #6:
This test does not cover (nor require) any API from libosmo-sigtran. It's a binary that links against libosmo-asn1-tcap and tests the API of libosmo-asn1-tcap. This is why it's weird to have such a test here: it just does not belong here.
It ensures the library works correctly. We had issues in the past with linking again asn1 libraries.
What kind of issues do we catch by having the test here that we would not be able to catch if we move it to libosmo-asn1-tcap.git? For the linker there's no difference where the test binary is...
To view, visit change 41308. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I8a0dbfaaa7182a5a72b279908be09e3adab254a2
Gerrit-Change-Number: 41308
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus <lynxis@fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: daniel <dwillmann@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis@fe80.eu>
Gerrit-Comment-Date: Mon, 10 Nov 2025 17:12:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu>