[M] Change in osmo-bsc[master]: pcu_sock: activate/deactivate PDCH on pcu reconnect - gerrit-log

3 Mar 2023

Attention is currently required from: neels, fixeria.

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31497
)

Change subject: pcu_sock: activate/deactivate PDCH on pcu reconnect
......................................................................

Patch Set 10:

(6 comments)

File doc/timeslot.msc:

https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/139c2582_e6a65a9b 
PS9, Line 95: bsc_ts box bsc_ts [label="release PDCH"];
            : 	...;
...
  ok i'll be happy if you replace these two lines
with […] Done

https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/f2cce9a6_705cfdc2 
PS9, Line 104: 	bsc_ts box bsc_ts [label="activate PDCH"];
             : 	...;
...
  ...and replace these two lines with […] Done

File src/osmo-bsc/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/8500a9dc_319c9581 
PS9, Line 803: 			 * not need any extra activation/deactivation of PDCHs. */
...
  i thought more like this: […] Done

https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/f3ba30fe_cc025c44 
PS9, Line 974: See comment above)
...
  it is not clear what this refers to ... just drop
this? or explicitly say what you mean to say. […] Yes, there is a lot of code in
between, I thought that this would be clear. I have now added a reference to the function
so that the comment can be found.

File src/osmo-bsc/timeslot_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/49772ed4_08921573 
PS9, Line 347: 	}
...
  ok so i added a move patch, pushed on branch
neels/for_dexter; you can rebase your branch like this: […] Thanks.

https://gerrit.osmocom.org/c/osmo-bsc/+/31497/comment/886e1b2e_4f2c2f11 
PS9, Line 1128: NOTE
...
  i'm really puzzled why you seem to start every
comment everywhere with "NOTE:" -- it is completely r […] I like to use it
to mark comments which I think are more important then other comments. Its normal comment
tag like FIXME, TODO etc, even some editors highlight it. I don't see anything wrong
with it.

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31497
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I9ea0c53a5e68a51c781ef43bae71f947cdb95678
Gerrit-Change-Number: 31497
Gerrit-PatchSet: 10
Gerrit-Owner: dexter &lt;pmaier(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Comment-Date: Fri, 03 Mar 2023 17:02:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-MessageType: comment