Attention is currently required from: neels, fixeria.

View Change

6 comments:

• File doc/timeslot.msc:

  • Patch Set #9, Line 95:

    bsc_ts box bsc_ts [label="release PDCH"];
    	...;
    

    ok i'll be happy if you replace these two lines with […]

    Done

  • Patch Set #9, Line 104:

    	bsc_ts box bsc_ts [label="activate PDCH"];
    	...;
    

    ...and replace these two lines with […]

    Done

• File src/osmo-bsc/pcu_sock.c:

  • Patch Set #9, Line 803: * not need any extra activation/deactivation of PDCHs. */

    i thought more like this: […]

    Done

  • Patch Set #9, Line 974: See comment above)

    it is not clear what this refers to ... just drop this? or explicitly say what you mean to say. […]

    Yes, there is a lot of code in between, I thought that this would be clear. I have now added a reference to the function so that the comment can be found.

• File src/osmo-bsc/timeslot_fsm.c:

  • Patch Set #9, Line 347: }

    ok so i added a move patch, pushed on branch neels/for_dexter; you can rebase your branch like this: […]

    Thanks.

  • Patch Set #9, Line 1128: NOTE

    i'm really puzzled why you seem to start every comment everywhere with "NOTE:" -- it is completely r […]

    I like to use it to mark comments which I think are more important then other comments. Its normal comment tag like FIXME, TODO etc, even some editors highlight it. I don't see anything wrong with it.

To view, visit change 31497. To unsubscribe, or for help writing mail filters, visit settings.