Attention is currently required from: fixeria.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262?usp=email )

Change subject: SGSN: add testcases for PDP Context Status ......................................................................

Patch Set 14:

(6 comments)

File sgsn/SGSN_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/5c9685bd_81a96... : PS10, Line 2446: [] BSSGP[ran_index].receive(tr_GMM_RAU_REJECT);

Do you eventually expect ACCEPT or REJECT? I see you permit both...

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/00a209d8_d20a8... : PS10, Line 2475: f_TC_attach_pdp_act_rau_pdp_ctx_status_ue_more

Am I correct that this function is 99% identical to `f_TC_attach_pdp_act_rau_pdp_ctx_status_same()` […]

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/81c51c53_bd2b4... : PS10, Line 2503: [] BSSGP[ran_index].receive(tr_GMM_RAU_REJECT);

Likewise, receiving a REJECT here will unblock the alt statement and the testcase will finish. […]

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/83b1793b_4e3ab... : PS10, Line 2548: as_gmm_auth

Is the authentication expected to happen before or after the procedures implemented in `as_ggsn_gtp_ […]

Correct behaviour: After the auth happened, _if_ this RAU doesn't have any encryption/integrity, but I doubt it is exactly like this already implemented.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/46b4eb75_13eed... : PS10, Line 2554: Timeout rx RAU Reject

This does not reflect the actual expectations...

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/5c43a303_74599... : PS10, Line 2574: [] BSSGP[ran_index].receive(tr_GMM_RAU_REJECT);

Same here: REJECT vs ACCEPT.

Done