Attention is currently required from: fixeria. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262?usp=email ) Change subject: SGSN: add testcases for PDP Context Status ...................................................................... Patch Set 14: (6 comments) File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/5c9685bd_81a96... : PS10, Line 2446: [] BSSGP[ran_index].receive(tr_GMM_RAU_REJECT);
Do you eventually expect ACCEPT or REJECT? I see you permit both... Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/00a209d8_d20a8... : PS10, Line 2475: f_TC_attach_pdp_act_rau_pdp_ctx_status_ue_more
Am I correct that this function is 99% identical to `f_TC_attach_pdp_act_rau_pdp_ctx_status_same()` […] Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/81c51c53_bd2b4... : PS10, Line 2503: [] BSSGP[ran_index].receive(tr_GMM_RAU_REJECT);
Likewise, receiving a REJECT here will unblock the alt statement and the testcase will finish. […] Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/83b1793b_4e3ab... : PS10, Line 2548: as_gmm_auth
Is the authentication expected to happen before or after the procedures implemented in `as_ggsn_gtp_ […] Correct behaviour: After the auth happened, _if_ this RAU doesn't have any encryption/integrity, but I doubt it is exactly like this already implemented.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/46b4eb75_13eed... : PS10, Line 2554: Timeout rx RAU Reject
This does not reflect the actual expectations... Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262/comment/5c43a303_74599... : PS10, Line 2574: [] BSSGP[ran_index].receive(tr_GMM_RAU_REJECT);
Same here: REJECT vs ACCEPT. Done
-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39262?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5a29e667f53cc2834fbddd2c5dc901d3e6ae72c7 Gerrit-Change-Number: 39262 Gerrit-PatchSet: 14 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Fri, 26 Sep 2025 19:48:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>