Attention is currently required from: laforge, pespin, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28849 )
Change subject: libosmonetify SMPP ......................................................................
Patch Set 61:
(4 comments)
File src/libsmpputil/smpp_smsc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/856e20e5_31b3bde1 PS49, Line 238: if (esme->use < 0)
Actually changing this check makes half of TTCN3 tests fail so I'd rather not mess with resource cou […]
Done
https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/bcdfc3e4_69c0b740 PS49, Line 825: static int esme_link_read_cb(struct osmo_stream_srv *conn)
Indeed, better rename it and make static. […]
Done
https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/dad4182a_6c7e5517 PS49, Line 851: static int esme_link_close_cb(struct osmo_stream_srv *conn)
Simply give a look at the code. For instance: […]
Done
File src/libsmpputil/smpp_vty.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28849/comment/5dd757de_0e88a90b PS49, Line 83: bool is_running = smsc->link;
Sure, if it was used more than once. For a single call I don't think it's worth it.
Done
-
msuraev