Attention is currently required from: laforge, pespin, fixeria.

View Change

4 comments:

• File src/libsmpputil/smpp_smsc.c:

  • Patch Set #49, Line 238: if (esme->use < 0)

    Actually changing this check makes half of TTCN3 tests fail so I'd rather not mess with resource cou […]

    Done

  • Patch Set #49, Line 825: static int esme_link_read_cb(struct osmo_stream_srv *conn)

    Indeed, better rename it and make static. […]

    Done

  • Patch Set #49, Line 851: static int esme_link_close_cb(struct osmo_stream_srv *conn)

    Simply give a look at the code. For instance: […]

    Done

• File src/libsmpputil/smpp_vty.c:

  • Patch Set #49, Line 83: bool is_running = smsc->link;

    Sure, if it was used more than once. For a single call I don't think it's worth it.

    Done

To view, visit change 28849. To unsubscribe, or for help writing mail filters, visit settings.